SSCSSI-e2e: improve hearings enabled pr setup #4002
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linusnorton
reviewed
Oct 4, 2024
linusnorton
reviewed
Oct 4, 2024
Jenkinsfile_CNP
Outdated
| @@ -136,7 +136,7 @@ withPipeline(type, product, component) { | |||
|
|
|||
| if (isHearingsPr) { | |||
| env.CASE_TYPE = "Benefit-${CHANGE_ID}" | |||
| setAatEnvVars(); | |||
| setAatEnvVarsForHearings(); | |||
There was a problem hiding this comment.
rather than making a whole new method with a lot of duplicate code I would call setAatEnvVars() and then put: env.TEST_E2E_API_URI = "https://sscs-tribunals-api-pr-${CHANGE_ID}.preview.platform.hmcts.net" at the end
There was a problem hiding this comment.
yes we can just override :)
nitinprabhuhmcts
previously approved these changes
Oct 4, 2024
linusnorton
added
pr-values:hearings
enable_keep_helm
and removed
enable_hearings
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
enable hearings pr setup for e2e tests on tribs
Testing done
Checklist