Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable slot HPy_tp_descr_get. #468

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Enable slot HPy_tp_descr_get. #468

merged 5 commits into from
Jan 29, 2024

Conversation

fangerer
Copy link
Contributor

This slot is needed for Cython/HPy because Cython has its own function type named cython_function_or_method.
In this PR, I also refactor autogen a bit such that it is a proper package that can be imported. We will use that in GraalPy to inject our own source code generators.

@fangerer fangerer added this to the ABI version 2 milestone Jan 26, 2024
Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HPy_tp_descr_get implementation and autogen refactoring look good.

@mattip Pinging you so that you know about the autogen changes in case they surprise you when you update the vendored copy in PyPy (assuming you still have one).

@mattip
Copy link
Contributor

mattip commented Jan 27, 2024

Thanks for the heads-up.

@fangerer fangerer merged commit 7bee0ac into master Jan 29, 2024
38 checks passed
@fangerer fangerer deleted the topic/GR-51605 branch January 29, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants