-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plot cleanup #34
Plot cleanup #34
Conversation
breznak
commented
Apr 30, 2020
- fix the issue with incorrect TP,FP in Plot
- cleanup plot code
for Results visualization. Fixes broken TP,FP computation. major cleanup
minor cleanup
into the single file (it was a trivial plot, added it to the former "Results" notebook.)
to avoid the spaces in file name in Linux
@Zbysekz can I have your review on this PR? I've addressed the issue with TP,TN we've talked about. And some cleanup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes. Good thing about the easier diff.
- In the second plot ( In[6] ) i can't see any data for "standard score", just the legend.
- The third plot ( In[7] ) shows just input value and input value mean? I would add some header comment on the beggining of In[7] to separate that
- Two first plots uses same data file that user can change at the beggining ("detector_summary_row") but third plot uses different data file?
About the line in In[13] with comment "TODO is this branch needed?" i suggest to delete the condition and also the second branch with zero indexes index. Add this line instead: |
yes, the main modifications were to "Plot Results ..." file, while there was also a "Plot Data " which did just that, a single plot of the data file. I've decided to merge it just in a single file (?)
I guess we can do that. I'd think it's for a compatibility with some older format, but currently NAB shouldn't change that much. I'll rm that |
fixed the value that wasn't plotted in recent changes. But I'm not sure about the meaning/correctness of the data.
thanks for spotting that. I've fixed the mistake I introduced and the data is being plotted. |
Thank you for your review, @Zbysekz . Please re-review when you have time, I've adressed the issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go