Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDRClassifier: fix precision by using Real64 for PDF #667

Merged
merged 11 commits into from
Sep 20, 2019
Merged

SDRClassifier: fix precision by using Real64 for PDF #667

merged 11 commits into from
Sep 20, 2019

Commits on Sep 16, 2019

  1. SDRClassifier: fix precision by using Real64 for PDF 

    without this, the scores never correctly converge(learn).
Thanks @Thanh-Binh for finding and solving this bug.

Additionally, add some docs to the class.
    @breznak
    breznak committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    ccf7e10 View commit details
    Browse the repository at this point in the history

  2. Classifier: more fixes 

    use Real64 for weights_ too, make some methods const
    @breznak
    breznak committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    d437a6a View commit details
    Browse the repository at this point in the history

  3. Classifier: make infer const 

    as inference should never change internal state,
    @breznak
    breznak committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    d34d0cd View commit details
    Browse the repository at this point in the history

  4. Predictor: make infer const 

    this removes updateHistory_() from inference, updateHistory code was
moved directly into learn() and rest split to a new method checkMonotonic_()
    @breznak
    breznak committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    bf5123b View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2019

  1. Merge branch 'master_community' into predictor_precision_fix

    @breznak
    breznak committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    2609617 View commit details
    Browse the repository at this point in the history

  2. review: formatting

    @breznak
    breznak committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    22d6664 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2019

  1. Merge branch 'master_community' into predictor_precision_fix

    @breznak
    breznak committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    4fd8fbb View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2019

  1. Merge branch 'master_community' into predictor_precision_fix

    @breznak
    breznak committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    767f89a View commit details
    Browse the repository at this point in the history

  2. Predictor: use hashmap

    @breznak
    breznak committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    2aedac2 View commit details
    Browse the repository at this point in the history

  3. Classifier: simplify asserts

    @breznak
    breznak committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    4d8708d View commit details
    Browse the repository at this point in the history

  4. Predictor: remove numRecord arg, fixes 

    as numRecord is no longer needed for inference. API changes to
bidings and tests to reflect the change.

Several fixes from earlier commits in this PR, this fixes the segfaults.
    @breznak
    breznak committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    df7ae4e View commit details
    Browse the repository at this point in the history