Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataarts/apis): add new resource to query apis under catalog #5484

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lance52259
Copy link
Collaborator

What this PR does / why we need it:
Supports a new data source to query API informations under a specified catalog.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. add new resource to query apis under catalog.

PR Checklist

  • Tests added/passed.
../coverage.sh  -o dataarts -f TestAccDataSourceDataServiceCatalogApis_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/dataarts" -v -coverprofile="./huaweicloud/services/acceptance/dataarts_coverage.cov" -coverpkg="./huaweicloud/services/dataarts" -run TestAccDataSourceDataServiceCatalogApis_basic -timeout 360m -parallel 10
=== RUN   TestAccDataSourceDataServiceCatalogApis_basic
--- PASS: TestAccDataSourceDataServiceCatalogApis_basic (197.01s)
PASS
coverage: 8.7% of statements in ./huaweicloud/services/dataarts
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dataarts  199.046s        coverage: 8.7% of statements in ./huaweicloud/services/dataarts
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Lance52259

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2024
@Lance52259 Lance52259 force-pushed the br_dataarts_apis_under_catalog branch from 0fc9f5b to 2a810ef Compare August 31, 2024 07:17
@Lance52259 Lance52259 force-pushed the br_dataarts_apis_under_catalog branch from 2a810ef to 7d5c7ae Compare August 31, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants