Merge pull request #1856 from theGreatWhiteShark/phil-fix-1854

Theme: fix default NoteOffColor

ChangeLog

@@ -2,6 +2,8 @@ XXXX-XX-XX the hydrogen team <hydrogen-devel@lists.sourceforge.net>
 	* Release 1.2.3
 	* Fixed
 		- Recorded MIDI notes were inserted ahead of the beat (#1851)
+		- Fixed NoteOff (stop note) color which was no different than
+			the default note color (#1854)
 
 2023-09-09 the hydrogen team <hydrogen-devel@lists.sourceforge.net>
 	* Release 1.2.2

data/themes/default.h2theme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <hydrogen_theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.hydrogen-music.org/theme">
- <version>1.2.0</version>
+ <version>1.2.2</version>
  <colorTheme>
   <songEditor>
    <backgroundColor>128,134,152</backgroundColor>
@@ -28,7 +28,7 @@
    <noteVelocityDefaultColor>40,40,40</noteVelocityDefaultColor>
    <noteVelocityHalfColor>89,131,175</noteVelocityHalfColor>
    <noteVelocityZeroColor>255,255,255</noteVelocityZeroColor>
-   <noteOffColor>0,0,0</noteOffColor>
+   <noteOffColor>71,79,191</noteOffColor>
    <lineColor>45,45,45</lineColor>
    <line1Color>55,55,55</line1Color>
    <line2Color>75,75,75</line2Color>

src/core/Preferences/Theme.cpp

@@ -52,7 +52,7 @@ ColorTheme::ColorTheme()
 	, m_patternEditor_noteVelocityDefaultColor( QColor( 40, 40, 40 ) )
 	, m_patternEditor_noteVelocityHalfColor( QColor( 89, 131, 175 ) )
 	, m_patternEditor_noteVelocityZeroColor( QColor( 255, 255, 255 ) )
-	, m_patternEditor_noteOffColor( QColor( 0, 0, 0 ) )
+	, m_patternEditor_noteOffColor( QColor( 71, 79, 191 ) )
 	, m_patternEditor_lineColor( QColor(45, 45, 45) )
 	, m_patternEditor_line1Color( QColor(55, 55, 55) )
 	, m_patternEditor_line2Color( QColor(75, 75, 75) )