Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoteOff notes are rendered as regular notes #1854

Closed
theGreatWhiteShark opened this issue Oct 2, 2023 · 2 comments
Closed

NoteOff notes are rendered as regular notes #1854

theGreatWhiteShark opened this issue Oct 2, 2023 · 2 comments

Comments

@theGreatWhiteShark
Copy link
Contributor

Hydrogen version * : 1.2.*


This picture from our docs nicely illustrates that the rendering of NoteOff notes is off. It looks exactly like a regular note although it does stop playback instead of triggering it. (such a note can be added by shift + left click)

theGreatWhiteShark added a commit to theGreatWhiteShark/hydrogen that referenced this issue Oct 3, 2023
Fixed NoteOff (stop note) color which was no different than the default note color (fixes hydrogen-music#1854)
@theGreatWhiteShark
Copy link
Contributor Author

Fixed in #1856

@theGreatWhiteShark
Copy link
Contributor Author

When thinking about this one twice it feels like there is some more work to be done in here. Just making the NoteOff a regular note with a blue color (for backward compatibility) just doesn't cut it. The meaning of a blue colored note is far from being obvious.

Instead, we could render NoteOff notes as x instead of the regular note shape. This more clearly shows its intention and it's probably quite easy to understand for users already using NoteOff notes in previous versions. (Coloring is still done using the same Theme option)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant