-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PatternEditor issues #1859
Comments
check for the instrument property when deleting a NoteOff note addresses hydrogen-music#1859
Hey @cme , In https://github.com/hydrogen-music/hydrogen/blob/master/src/gui/src/PatternEditor/PatternEditor.cpp#L237 NoteOff notes are intentionally excluded from being selected and rendered as selected. Do you know why? I never used them in a real song but just quickly toying with them feels super strange as they do not behave like regular notes. |
Looks like I accidentally inherited that logic from the original drag event handlers which were set up only to handle start notes because the previous functionality was to change the lengths by dragging. No explicit stop notes in the demo songs meant I ended up not noticing. |
Alright. That's what I thought. I almost forgot about them too. One of those more hidden features |
check for the instrument property when deleting a NoteOff note addresses hydrogen-music#1859
Hydrogen version * : 1.2
I just experienced some very strange behavior in the Pattern Editor
-> the notes will disappear and don't show up in the .h2song when saving now. This shouldn't be possible
-> the notes reappear as NoteOff notes which can neither be selected using mouse dragging or Ctrl + A. WTF?
Edit: moving notes out of the pattern is probably not a bad idea. But undo has to work.
The text was updated successfully, but these errors were encountered: