Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: relax connection IO trait bounds #3595

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Conversation

ehaydenr
Copy link
Contributor

@ehaydenr ehaydenr commented Mar 5, 2024

I can't tell if this was intentional. hyper 0.14.x didn't have this requirement and as far as I can tell it's not actually needed.

@dswij
Copy link
Member

dswij commented Mar 15, 2024

For context, I believe that this is here for

pub fn without_shutdown(self) -> impl Future<Output = crate::Result<Parts<I, S>>>
.

But the Connection impl itself, and Dispatch does not require this bound, so it's safe to remove this from impl Future.

@dswij dswij changed the title relax connection IO trait bounds feat: relax connection IO trait bounds Mar 15, 2024
@dswij dswij merged commit 0013bdd into hyperium:master Mar 15, 2024
21 checks passed
@dswij
Copy link
Member

dswij commented Mar 15, 2024

Thank you! @ehaydenr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants