tonic-reflection: Refactor descriptor parser to be separate #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of reintroducing the v1alpha reflection support, this extracts the parser into a separate module.
|
This should be superseded by #1888. @ttkjesper please close if you find #1888 satisfactory. |
|
Tested and verified the merged PR with our local codebase - confirmed working great. 👍 Happy to close. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of reintroducing the v1alpha reflection support, this extracts the parser into a separate module.
Motivation
If we were to naively reintroduce the v1alpha support, there would be a lot of code duplication.
Solution
The parser is extracted into a separate module that can be shared between both protocols.