Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor install script #262

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Refactor install script #262

merged 2 commits into from
Oct 25, 2023

Conversation

yonahd
Copy link
Contributor

@yonahd yonahd commented Feb 16, 2023

This makes the script a little bit cleaner and also adds compatibility since any unix/linux OS will have an sh shell

@yonahd
Copy link
Contributor Author

yonahd commented Feb 16, 2023

@hypnoglow can you review?

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dec1481) 41.53% compared to head (00b0e68) 41.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   41.53%   41.53%           
=======================================
  Files          19       19           
  Lines         508      508           
=======================================
  Hits          211      211           
  Misses        287      287           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hypnoglow hypnoglow added this to the 0.16.0 milestone Oct 25, 2023
@hypnoglow
Copy link
Owner

Thanks!

@hypnoglow hypnoglow merged commit 00344c1 into hypnoglow:master Oct 25, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants