Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable auth for tests #555

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Disable auth for tests #555

merged 4 commits into from
Aug 21, 2023

Conversation

br648
Copy link
Contributor

@br648 br648 commented Aug 16, 2023

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

73 exceptions are logged as part of CI for failed authentication. Auth isn't needed for the majority of unit tests, so where the exception is thrown, auth has been disabled. It is re-enabled once the test has completed so as not to impact tests that do require auth.

This PR (where applicable) disables auth which will remove the exceptions logged and speed up testing... a little.

Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no better place to put all these calls? Feels annoying to have to repeat it so many times

@br648
Copy link
Contributor Author

br648 commented Aug 16, 2023

Is there no better place to put all these calls? Feels annoying to have to repeat it so many times

@miles-grant-ibigroup not without a more indepth refactor. Some of the tests require auth so a global update (say in DatatoolsTest.setUp()) is not possible. If I was to do this, I'd have to update all the tests that require auth (to enable it), so I don't think we'd be any further forward.

@br648 br648 assigned binh-dam-ibigroup and unassigned br648 Aug 16, 2023
@br648 br648 merged commit ab1475e into dev Aug 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants