Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to enum use and parameterized unit tests #585

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Updates to enum use and parameterized unit tests #585

merged 1 commit into from
Jan 16, 2024

Conversation

br648
Copy link
Contributor

@br648 br648 commented Jan 12, 2024

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • e2e tests are all passing (remove this if not merging to master)

Description

Updates to enum use and parameterized unit tests.

@br648 br648 mentioned this pull request Jan 12, 2024
Merged
7 tasks
miles-grant-ibigroup
miles-grant-ibigroup approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks so much for this improvement

@miles-grant-ibigroup miles-grant-ibigroup merged commit dbf47d3 into shared-stops-validator-repair Jan 16, 2024
2 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the shared-stops-validator-repair-rb branch January 16, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@br648 @miles-grant-ibigroup