Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mint): cleanup module #58

Merged
merged 11 commits into from
Oct 1, 2022
Merged

refactor(mint): cleanup module #58

merged 11 commits into from
Oct 1, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Sep 27, 2022

Basic cleanup and refactoring of the mint module.

  • Make all minting functions take sdk.Coin args instead of some taking sdk.Coins and some taking sdk.Coin
  • Remove some dead code
  • move simulation code to module_simulation.go
  • move BeginBlocker logic to keeper package so it can be tested in a later PR

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #58 (5617258) into main (53940aa) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #58   +/-   ##
=====================================
  Coverage   9.21%   9.21%           
=====================================
  Files         50      50           
  Lines       8875    8875           
=====================================
  Hits         818     818           
  Misses      8034    8034           
  Partials      23      23           
Impacted Files Coverage Δ
x/mint/keeper/abci.go 0.00% <0.00%> (ø)
x/mint/types/genesis.go 0.00% <0.00%> (ø)

Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumtis lumtis merged commit 622a29a into main Oct 1, 2022
@lumtis lumtis deleted the refactor/mint branch October 1, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants