Fix chroma shift and bump version to 2.4b

ikorb · Sep 14, 2018 · eacc609 · eacc609
1 parent f87f0f5
commit eacc609
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 6 deletions.
diff --git a/Firmware/screen_about.c b/Firmware/screen_about.c
@@ -1,6 +1,6 @@
 /* GCVideo DVI Firmware
 
-   Copyright (C) 2015-2017, Ingo Korb <ingo@akana.de>
+   Copyright (C) 2015-2018, Ingo Korb <ingo@akana.de>
    All rights reserved.
 
    Redistribution and use in source and binary forms, with or without
@@ -80,7 +80,7 @@ void screen_about(void) {
       osd_putsat(14, 11, "GCVideo DVI v" VERSION);
     }
   }
-  osd_putsat(12, 13, "Copyright \013 2015-2017");
+  osd_putsat(12, 13, "Copyright \013 2015-2018");
   osd_putsat(16, 14, "by Ingo Korb");
   osd_putsat(15, 15, "ingo@akana.de");
   osd_gotoxy(14, 17);

diff --git a/HDL/gcvideo_dvi/Makefile b/HDL/gcvideo_dvi/Makefile
@@ -1,6 +1,6 @@
 # FIXME: Header, make-it-work, etc.
 
-VERSION := 2.4a
+VERSION := 2.4b
 
 SRC_COMMON := \
 	src/Blanking_Regenerator_Fixed.vhd \

diff --git a/HDL/gcvideo_dvi/src/convert_yuv_to_rgb.vhd b/HDL/gcvideo_dvi/src/convert_yuv_to_rgb.vhd
@@ -1,6 +1,6 @@
 ----------------------------------------------------------------------------------
 -- GCVideo DVI HDL
--- Copyright (C) 2014-2017, Ingo Korb <ingo@akana.de>
+-- Copyright (C) 2014-2018, Ingo Korb <ingo@akana.de>
 -- All rights reserved.
 --
 -- Redistribution and use in source and binary forms, with or without
@@ -58,6 +58,7 @@ architecture Behavioral of convert_yuv_to_rgb is
   signal rtemp : signed(18 downto 0) := (others => '0'); -- Cr for R
   signal gtempr: signed(18 downto 0) := (others => '0'); -- Cr for G
   signal gtempb: signed(18 downto 0) := (others => '0'); -- Cb for G
+  signal gtmpb2: signed(18 downto 0) := (others => '0'); -- Cb for G, delayed
   signal btemp : signed(18 downto 0) := (others => '0'); -- Cb for B
 
   signal rsum    : signed(18 downto 0) := (others => '0'); -- (Y + rtemp) / 256
@@ -127,11 +128,12 @@ begin
       -- pipeline stage 2: add/subtract
       rsum     <= (ystore + rtemp) / 256;
       gsumtemp <= ystore - gtempr;
+      gtmpb2   <= gtempb;
       bsum     <= (ystore + btemp) / 256;
 
       -- pipeline stage 3: clipping r/b, subtract g
       rout <= clip(rsum);
-      gsum <= (gsumtemp - gtempb) / 256;
+      gsum <= (gsumtemp - gtmpb2) / 256;
       bout <= clip(bsum);
 
       -- pipeline stage 4: clip g, output

diff --git a/NEWS b/NEWS
@@ -1,3 +1,6 @@
+2018-09-14: GCVideo-DVI version 2.4b
+- fix a slight chroma shift in YCbCr-to-RGB conversion
+
 2017-12-10: GCVideo-DVI version 2.4a
 - fix audio issues introduced by 2.4 for some board configurations
 - ensure that the mode popup is always shown with correct colors

diff --git a/README.md b/README.md
@@ -71,7 +71,7 @@ should contain README.md files with further information.
 # Licence #
 
 <pre>
-Copyright (C) 2014-2017, Ingo Korb &lt;ingo@akana.de&gt;
+Copyright (C) 2014-2018, Ingo Korb &lt;ingo@akana.de&gt;
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without