Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: automatically open sidebar block menu on build preview #7332

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Mar 26, 2024

Resolves # GIVE-536

Description

When opening the build section of the visual form builder we want the left sidebar menu set to open automatically as a way to ensure users can easily find new blocks to add.

The state that manages which sidebar is open can be found as selectedSecondarySidebar in the BlockEditorInterfaceSkeletonContainer component. This state manages both the list view and the block menu.

This PR applies the name of the sidebar add as a default for the open state that manages the secondary sidebar which will ensure that the block menu is open when selecting the build preview section.

Additionally an unused import was removed.

Affects

  • Visual Form Builder
  • Sidebars

Visuals

Screen.Recording.2024-03-26.at.3.20.46.PM.mov

Testing Instructions

  • Create a v3 form
  • Select the build section to verify the left sidebar with the block menu opens automatically.
  • Test out the other sidebars in both the build & design preview sections.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magnificent! 🥇

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@JoshuaHungDinh JoshuaHungDinh merged commit 5386b28 into develop Mar 28, 2024
20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the refactor/blockmenu-opens-on-build branch March 28, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants