Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Enhance Donation Form block to display up to 100 forms #7347

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Fix: Enhance Donation Form block to display up to 100 forms #7347

merged 2 commits into from
Apr 10, 2024

Conversation

pauloiankoski
Copy link
Contributor

@pauloiankoski pauloiankoski commented Apr 8, 2024 •
edited
Loading

Resolves GIVE-487

Description

The Donation Form block currently displays only the last 10 donation forms. This pull request increases the limit to 100, aiming to cover most cases effectively.

Read more

Affects

Donation Form block

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@pauloiankoski pauloiankoski changed the title fix: change Donation Form block selector to list 100 option Fix: Enhance Donation Form block to display up to 100 forms Apr 8, 2024
JoshuaHungDinh
JoshuaHungDinh approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed we consistently use ts-ignore for the select function. At some point we should find why the types are not imported properly. I could probably do it on Friday. Any general thoughts?

@pauloiankoski
Copy link
Contributor Author

I noticed we consistently use ts-ignore for the select function. At some point we should find why the types are not imported properly. I could probably do it on Friday. Any general thoughts?

Yeah! Definitely that's an area to improve in our codebase.

rickalday
rickalday approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests

@jonwaldstein jonwaldstein merged commit 57ac936 into develop Apr 10, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/donation-forms-block-selector branch April 10, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickalday rickalday rickalday approved these changes

@JoshuaHungDinh JoshuaHungDinh JoshuaHungDinh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pauloiankoski @rickalday @JoshuaHungDinh @jonwaldstein