Feature: Add migration step for Currency Switcher #7397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonwaldstein
requested changes
May 28, 2024
Comment on lines
989
to
1007
| public function getCurrencySwitcherStatus(): string | ||
| { | ||
| return $this->getMeta('cs_status'); | ||
| } | ||
|
|
||
| /** | ||
| * @unreleased | ||
| */ | ||
| public function getCurrencySwitcherMessage(): string | ||
| { | ||
| return $this->getMeta('cs_message'); | ||
| } | ||
|
|
||
| /** | ||
| * @unreleased | ||
| */ | ||
| public function getCurrencySwitcherDefaultCurrency(): string | ||
| { | ||
| return $this->getMeta('give_cs_default_currency'); |
There was a problem hiding this comment.
Can we add default values for these? That's the tricky part with meta as we want to expect a return type but it's also possible for the meta to not exist.
Please also updated TestFormMetaDecorator 😄
| */ | ||
| public function process() | ||
| { | ||
| $status = $this->formV2->getCurrencySwitcherStatus(); |
There was a problem hiding this comment.
Does this v2 status need to be used in v3 form settings to determine global or customize?
There was a problem hiding this comment.
Yeah. This is a 1-to-1 setting.
jonwaldstein
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-679
Description
This pull request adds a new FormMigration step that migrates Currency Switcher settings from v2 forms to v3.
Affects
Form Migration
Testing Instructions
Pre-review Checklist
@unreleasedtags included in DocBlocks