Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: throw error message instead of the error object when submitting an donation made with Stripe Element gateway #7399

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented May 30, 2024

Resolves GIVE-345

Description

This PR fixes the error message that was being displayed in certain cases as [object Object] when a donation made with Stripe Element gateway was submitted. Now we are displaying a proper string to indicate the error instead of an object.

Affects

The Stripe Element gateway

Visuals

image

Testing Instructions

Credit Card:

  1. Create a donation and miss any of CC #, expiry, or CVV and press Donate;
  2. The new friendly error message will show above the Donate button.

Google Pay:

  1. Enable Google Pay in your Stripe Dashboard;
  2. Create a donation and press Donate, a modal should be opened;
  3. Close the Google modal;
  4. The new friendly error message will show above the Donate button.

To set up Google Pay in your Chrome for Desktop, check out this link: https://givewp.com/documentation/add-ons/stripe-gateway/stripe-apple-pay-google-pay/

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this May 30, 2024
@glaubersilva glaubersilva marked this pull request as ready for review May 30, 2024 13:51
@glaubersilva
Copy link
Contributor Author

@jonwaldstein This is ready for re-review.

Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, looks good 👍

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@glaubersilva glaubersilva merged commit c1b7ae5 into develop Jun 4, 2024
20 checks passed
@glaubersilva glaubersilva deleted the fix/missing-message-error-GIVE-345 branch June 4, 2024 19:57
kjohnson pushed a commit that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants