-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add a checkbox option to keep the PayPal webhooks after disconnect the account #7407
Feature: add a checkbox option to keep the PayPal webhooks after disconnect the account #7407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me! I've reached out to @Benunc for a copy check on this. Let's also do a quick DQA on this with @jdghinson before sending it to QA.
@jdghinson I recorded a short video demonstrating the visual changes implemented in this PR and would like to get your review on it, here is the link: https://www.loom.com/share/b0dd84e1ba1e4d709e5f1509f6ce256e?sid=50f462e5-62e2-434f-bb85-f9bc7fae7a75 If you need a zip file to install it and check closer, let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed manual QA tests.
Resolves GIVE-854
Description
This PR adds an option to keep the PayPal webhooks config when disconnecting an account, this way we can keep receiving webhook events, including subscription renewals, from the old account.
Affects
PayPal donations, especially the recurring donations.
Visuals
Demo video: https://www.loom.com/share/4bd1ad7a2ecc48d4b875f797425ee30e?sid=258ede42-918b-4342-991a-3f989ed22ff1
Testing Instructions
give_paypal_commerce_sandbox_webhook_config
is present in your DBgive_paypal_commerce_sandbox_webhook_config
keeps present in your DBTo check if the
give_paypal_commerce_sandbox_webhook_config
is present in your DB, use the following query:Pre-review Checklist
@unreleased
tags included in DocBlocks