Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: improve block insertion point indicator's position when inserting from the block menu #7414

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix: improve block insertion point indicator's position when inserting from the block menu #7414

merged 1 commit into from
Jul 9, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Jun 14, 2024 •
edited by jira bot
Loading

Resolves GIVE-537

Description

This Main purpose of this PR is to address an issue where the block insertion point indicator is inside of a block.
block-placement-indicator

Affects

Block Preview in VFB forms

Visuals

block-indicator.mov

Testing Instructions.

  • On the build preview select some blocks in the visual form builder.
  • Open the left sidebar block inserter menu.
  • Hover over a block in the menu.
  • Verify the insertion indicator does not display inside of any block.
  • Should be tested on the last 3 versions of WordPress, be sure to try all the blocks in the preview.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review June 18, 2024 15:46
@JoshuaHungDinh JoshuaHungDinh changed the title refactor: improve block insertion point indicator's position spacing when inserting from the block menu refactor: improve block insertion point indicator's position when inserting from the block menu Jun 18, 2024
@JoshuaHungDinh JoshuaHungDinh changed the title refactor: improve block insertion point indicator's position when inserting from the block menu Refactor: improve block insertion point indicator's position when inserting from the block menu Jun 18, 2024
@JoshuaHungDinh JoshuaHungDinh changed the title Refactor: improve block insertion point indicator's position when inserting from the block menu Fix: improve block insertion point indicator's position when inserting from the block menu Jun 18, 2024
@JoshuaHungDinh JoshuaHungDinh force-pushed the fix/drag-and-drop-line-indicator-placement branch from 2cadf2f to 872fb78 Compare June 25, 2024 14:31
rickalday
rickalday approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests

@JoshuaHungDinh JoshuaHungDinh merged commit aaac24a into develop Jul 9, 2024
20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the fix/drag-and-drop-line-indicator-placement branch July 9, 2024 16:58
kjohnson pushed a commit that referenced this pull request Aug 21, 2024
@JoshuaHungDinh @kjohnson
Fix: improve block insertion point indicator's position when insertin…
93cfcbc 
…g from the block menu (#7414)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaHungDinh @rickalday