Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: don't prevent PayPal donations from getting finished when there is no Billing Address block in the form #7416

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Fix: don't prevent PayPal donations from getting finished when there is no Billing Address block in the form #7416

merged 2 commits into from
Jun 19, 2024

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Jun 17, 2024 •
edited
Loading

Resolves GIVE-895

Description

This PR fixes a bug introduced in #7405 which prevents PayPal donations from getting finished when there is no Billing Address block added in the form.

To accomplish that, all we need to do is check if the country field is set, otherwise, we ignore the validations for city, state, and zip fields.

Affects

The PayPal Donations

Visuals

Testing Instructions

  1. Enable PayPal donations
  2. Create a V3 form without an address block
  3. Create a test donation using the PP smart buttons and make sure it works.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Jun 17, 2024
@glaubersilva glaubersilva marked this pull request as ready for review June 17, 2024 19:57
@jonwaldstein jonwaldstein self-requested a review June 17, 2024 20:14
jonwaldstein
jonwaldstein approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should do it 👍

rickalday
rickalday approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests

@jonwaldstein jonwaldstein merged commit 69f920a into master Jun 19, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the hotfix/paypal-address-block-GIVE-895 branch June 19, 2024 15:17
@jonwaldstein jonwaldstein changed the title Hot Fix: don't prevent PayPal donations from getting finished when there is no Billing Address block in the form Fix: don't prevent PayPal donations from getting finished when there is no Billing Address block in the form Jun 19, 2024
kjohnson pushed a commit that referenced this pull request Aug 21, 2024
@glaubersilva @kjohnson
Hot Fix: don't prevent PayPal donations from getting finished when th…
4e0dbcb 
…ere is no Billing Address block in the form (#7416)

Co-authored-by: Jon Waldstein <jonwaldstein@jwaldstein-mbp.mynetworksettings.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickalday rickalday rickalday approved these changes

@jonwaldstein jonwaldstein jonwaldstein approved these changes

Assignees

@glaubersilva glaubersilva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glaubersilva @rickalday @jonwaldstein