Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: standardize primary color on VFB input borders #7427

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Refactor: standardize primary color on VFB input borders #7427

merged 1 commit into from
Jul 9, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Jun 28, 2024 •
edited
Loading

Resolves: GIVE-818

Description

This change ensures all inputs in the visual form builder are standardized with the primary color applied to the border. This is necessary for some of the blocks in our addons which display a grey border with high specificity.

Affects

VFB inputs

Visuals

checkbox-border.mov

Testing Instructions

  • Install FFM, add a checkbox block.
  • View design mode and click on the checkbox.
  • Click away from the checkbox on the form verify the border color is not grey.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review July 8, 2024 13:55
rickalday
rickalday approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@JoshuaHungDinh JoshuaHungDinh merged commit 2585584 into develop Jul 9, 2024
4 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the refactor/input-border-color branch July 9, 2024 23:31
kjohnson pushed a commit that referenced this pull request Aug 21, 2024
@JoshuaHungDinh @kjohnson
Refactor: standardize primary color on VFB input borders (#7427)
b1ac0f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickalday rickalday rickalday approved these changes

@pauloiankoski pauloiankoski pauloiankoski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaHungDinh @rickalday @pauloiankoski