Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update default colors in PanelColorSettings #7437

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Jul 8, 2024

Resolves: https://stellarwp.atlassian.net/browse/GIVE-807

Description

This PR includes a temporary fix for the PanelColorSettings default color list. The original default colors included "White" which could not be seen on the form. It along with the rest of the default colors to choose from have been updated. In the future we will look into integrating theme.json for the Visual Form Builder to handle presets.

Affects

Visual Form Builder

Visuals

Screen Shot 2024-07-08 at 8 02 51 AM

Testing Instructions

  • In the Visual Form Builder, open the Styles sidebar in Design mode
  • Select both color controls and verify the new default color list.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@JoshuaHungDinh JoshuaHungDinh merged commit 054ae8e into develop Jul 30, 2024
20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the feature/vfb-color-pallete branch July 30, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants