Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add Razorpay per-form settings migration step #7438

Merged

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Jul 9, 2024

Resolves GIVE-934

Related PR: https://github.com/impress-org/give-razorpay/pull/84

Description

This PR adds a new form migration step to ensure that the Razorpay per-form settings will be migrated to new V3 forms.

Affects

The form migration process.

Visuals

image

image

Testing Instructions

  1. Set up a v2 form and setup Razorpay per-form settings;
  2. Migrate the form created in the previous step to a v3 form;
  3. Make sure the settings from step 1 were migrated and available in the Payment Gateways block settings.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Jul 9, 2024
@glaubersilva glaubersilva marked this pull request as ready for review July 9, 2024 21:43
@glaubersilva
Copy link
Contributor Author

@jonwaldstein This is ready for re-review.

Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glaubersilva thanks for the update, great job!

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@glaubersilva glaubersilva merged commit 4cd7a20 into develop Jul 11, 2024
20 checks passed
@glaubersilva glaubersilva deleted the feature/razorpay-form-settings-migration-GIVE-934 branch July 11, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants