-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add Razorpay per-form settings migration step #7438
Merged
glaubersilva
merged 7 commits into
develop
from
feature/razorpay-form-settings-migration-GIVE-934
Jul 11, 2024
Merged
Feature: add Razorpay per-form settings migration step #7438
glaubersilva
merged 7 commits into
develop
from
feature/razorpay-form-settings-migration-GIVE-934
Jul 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonwaldstein
requested changes
Jul 11, 2024
@jonwaldstein This is ready for re-review. |
jonwaldstein
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glaubersilva thanks for the update, great job!
rickalday
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed manual QA tests.
glaubersilva
deleted the
feature/razorpay-form-settings-migration-GIVE-934
branch
July 11, 2024 15:28
kjohnson
pushed a commit
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-934
Related PR: https://github.com/impress-org/give-razorpay/pull/84
Description
This PR adds a new form migration step to ensure that the Razorpay per-form settings will be migrated to new V3 forms.
Affects
The form migration process.
Visuals
Testing Instructions
Pre-review Checklist
@unreleased
tags included in DocBlocks