Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx: use capabilities check #7440

Merged
merged 3 commits into from
Jul 17, 2024
Merged

FIx: use capabilities check #7440

merged 3 commits into from
Jul 17, 2024

Conversation

alaca
Copy link
Member

@alaca alaca commented Jul 10, 2024

Resolves GIVE-979

Description

This PR resolves the issue where users with edit_give_forms capabilities like the give_worker role could delete any post or page. The problem is resolved by checking if the user has the right capability for handling posts.

Pre-review Checklist

@alaca alaca requested a review from jonwaldstein July 10, 2024 14:00
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jonwaldstein
Copy link
Contributor

@jonwaldstein
Copy link
Contributor

This PR has been updated to validate the post type request to make sure it is a give form

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests

@jonwaldstein jonwaldstein merged commit 0c9bc54 into develop Jul 17, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/post-actions-GIVE-979 branch July 17, 2024 16:51
kjohnson pushed a commit that referenced this pull request Aug 21, 2024
Co-authored-by: Jon Waldstein <jonwaldstein@jwaldstein-mbp.mynetworksettings.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants