Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: hide block inserter tabs introduced in WP 6.6 #7453

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix: hide block inserter tabs introduced in WP 6.6 #7453

merged 1 commit into from
Jul 17, 2024

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Jul 17, 2024 •
edited by jira bot
Loading

Resolves GIVE-1021

Description

This hides the new block inserter tabs introduced in WP 6.6 from our form builder block inserter sidebar.

Affects

The block inserter in the form builder

Visuals

Before:

Screenshot 2024-07-17 at 10 20 36 AM

After:

Screenshot 2024-07-17 at 10 20 43 AM

Testing Instructions

  • Instal WP 6.6
  • View the v3 form block inserter
  • There should be no extra tabs and it should work as expected

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein marked this pull request as ready for review July 17, 2024 14:21
JoshuaHungDinh
JoshuaHungDinh approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & working. This is good to go 👍

@jonwaldstein jonwaldstein merged commit f2847bf into develop Jul 17, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/hide-block-inserter-tabs branch July 17, 2024 14:54
kjohnson pushed a commit that referenced this pull request Aug 21, 2024
@jonwaldstein @kjohnson
Fix: hide block inserter tabs introduced in WP 6.6 (#7453)
0279e5b 
Co-authored-by: Jon Waldstein <jonwaldstein@jwaldstein-mbp.mynetworksettings.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaHungDinh JoshuaHungDinh JoshuaHungDinh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonwaldstein @JoshuaHungDinh