Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Update step 1 of the Setup Guide #7457

Merged

Conversation

pauloiankoski
Copy link
Contributor

@pauloiankoski pauloiankoski commented Jul 22, 2024

Resolves GIVE-970

Description

This pull request updates the Step 1 of the Setup Guide. There are three states for it:

  1. When the wizard has been skipped, it is shown as Not Completed, and the action button targets the wizard with the label Configure GiveWP.
  2. When the wizard has been completed successfully, the action button targets the new form for editing.
  3. When the wizard has been completed but the created form has already been deleted, the action button targets the list of forms.

Affects

Step 1: Setup Guide

Visuals

dev givewp local_wp-admin_edit php_post_type=give_forms page=give-setup (1)
dev givewp local_wp-admin_edit php_post_type=give_forms page=give-setup (2)

Testing Instructions

  1. In a new install, close the wizard directly and go to the Setup Guide. State 1 should be presented.
  2. Click on the Configure GiveWP button and follow the wizard. At the end, you’ll be redirected to the Setup Guide, and state 2 should be presented. Clicking the Configure form button should open the edit form page.
  3. Delete the recently created form, then go to the Setup Guide once again. Clicking the Configure form button should open the forms list table.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@pauloiankoski pauloiankoski changed the title Refactor: Update step 1 of Setup Guide Refactor: Update step 1 of the Setup Guide Jul 22, 2024
Copy link
Contributor

@glaubersilva glaubersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pauloiankoski Great work! I just left a few comments related to minor things to be addressed before sending it to QA.

src/Onboarding/Setup/templates/index.html.php Outdated Show resolved Hide resolved
src/Onboarding/Setup/templates/index.html.php Outdated Show resolved Hide resolved
src/Onboarding/Setup/templates/index.html.php Outdated Show resolved Hide resolved
src/Onboarding/Setup/templates/index.html.php Outdated Show resolved Hide resolved
src/Onboarding/Setup/templates/action-button.html Outdated Show resolved Hide resolved
src/Onboarding/Setup/templates/index.html.php Show resolved Hide resolved
Copy link
Contributor

@glaubersilva glaubersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pauloiankoski Looks great, ready to QA.

@jonwaldstein jonwaldstein changed the base branch from develop to epic/setup-guide-GIVE-791 August 7, 2024 18:40
@jonwaldstein jonwaldstein merged commit 4a5d237 into epic/setup-guide-GIVE-791 Aug 7, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the refactor/update-setup-guide-1 branch August 7, 2024 18:44
kjohnson pushed a commit that referenced this pull request Aug 21, 2024
Co-authored-by: Jon Waldstein <jon@givewp.com>
Co-authored-by: Jon Waldstein <jonwaldstein@jwaldstein-mbp.mynetworksettings.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants