Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add give-form-title and give_title to serialized fields check #7461

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Jul 24, 2024

Resolves GIVE-654, GIVE-980

Description

This adds give-form-title & give_title to serialized fields check

Affects

v2 form processing

Visuals

N/A

Testing Instructions

ZIP: https://github.com/impress-org/givewp/actions/runs/10144972557

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein requested a review from alaca July 24, 2024 13:12
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed automated QA tests.

@alaca alaca mentioned this pull request Jul 31, 2024
2 tasks
@jonwaldstein jonwaldstein changed the title Fix: add give-form-title to serialized fields check Fix: add give-form-title and give_title to serialized fields check Aug 2, 2024
@jonwaldstein jonwaldstein merged commit 39d41fc into master Aug 7, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/GIVE-654 branch August 7, 2024 12:42
kjohnson pushed a commit that referenced this pull request Aug 21, 2024
…7461)

Co-authored-by: Jon Waldstein <jonwaldstein@jwaldstein-mbp.mynetworksettings.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants