Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: change "Add Form" button link and styles #7462

Merged
merged 6 commits into from
Jul 30, 2024

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Jul 25, 2024

Resolves GIVE-999

Description

This PR makes the "Add Form" button from the form list view create a new form using the visual form builder. It also updates the styles to keep the consistency with the WordPress secondary and primary buttons.

Affects

The "Add Form" button from the form list view.

Visuals

https://www.loom.com/share/caff9f3671eb4defab5b470e391ae55e?sid=e9fee7e0-7817-4af9-ae05-1d9228918d74

Testing Instructions

  1. Go to Give > All Forms and make sure the new styles are applied to the buttons;
  2. Go to User > Profile and change the admin color scheme;
  3. Check if the new color schema got applied to the buttons;
  4. Click on the "Add Form" button and make sure it's creating new forms using the Visual Form Builder.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Jul 25, 2024
@glaubersilva glaubersilva changed the title Refactor: change add form link and use WP button classes Refactor: change "Add Form" button link and styles Jul 25, 2024
@glaubersilva glaubersilva marked this pull request as ready for review July 26, 2024 13:20
Copy link

@jdghinson jdghinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@pauloiankoski
Copy link
Contributor

@jdghinson Currently, the buttons are being styled slightly different from WP native buttons (32px vs 30px height and 500 vs 400 font-weight). Was that intentional?

CleanShot 2024-07-29 at 13 02 20
Native on top, modified on bottom

@jdghinson
Copy link

@pauloiankoski Yes, the native looks smaller.

@glaubersilva
Copy link
Contributor Author

@pauloiankoski This is ready for re-review.

Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@glaubersilva glaubersilva merged commit 4bfb893 into develop Jul 30, 2024
20 checks passed
@glaubersilva glaubersilva deleted the refactor/add-form-button-GIVE-999 branch July 30, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants