Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Form Builder Tags, Categories #7463

Merged
merged 33 commits into from
Aug 20, 2024

Conversation

kjohnson
Copy link
Member

@kjohnson kjohnson commented Jul 30, 2024

Resolves GIVE-927

Description

This PR adds a new Domain for Form Taxonomies, which includes form tags and form categories as custom taxonomies.

Affects

Add the $request as an additional parameter to the givewp_form_builder_updated action hook.

Testing Instructions

Enable form tags and/or form categories in the Give settings.

Create a new donation form and add/remove form tags and form categories.

Visuals

Tags & Categories
image

@kjohnson kjohnson marked this pull request as ready for review July 30, 2024 18:52
@jonwaldstein
Copy link
Contributor

jonwaldstein commented Jul 31, 2024

@kjohnson please fill out the PR description with what this affects and testing instructions. Also, in order for the jira ticket to be linked using resolves you need to add the brackets around it like this GIVE-927

@kjohnson
Copy link
Member Author

@jonwaldstein
Copy link
Contributor

@kjohnson another thought here, have we already accounted for taxonomies in the v2 to v3 form migration process? If not, can you please add a migration step?

@kjohnson
Copy link
Member Author

kjohnson commented Aug 8, 2024

@jonwaldstein thanks for the feedback on how to better separate this domain without using temporary form settings. Always good to get a second set of eyes with a "non-standard" approach.

I'll get that updates.

Also, I'll look into the form migration - good catch.

@kjohnson
Copy link
Member Author

@jonwaldstein Re: Form Migration: I created a new task in Jira, see https://stellarwp.atlassian.net/browse/GIVE-1119.

src/FormTaxonomies/Actions/EnqueueFormBuilderAssets.php Outdated Show resolved Hide resolved
webpack.mix.js Outdated Show resolved Hide resolved
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kjohnson nice job! just one more request for a unit test, otherwise looks good & ready for QA 🌈

src/FormTaxonomies/Actions/UpdateFormTaxonomies.php Outdated Show resolved Hide resolved
@kjohnson
Copy link
Member Author

@kjohnson kjohnson removed the request for review from pauloiankoski August 19, 2024 15:07
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@kjohnson kjohnson merged commit 0fa13f4 into develop Aug 20, 2024
20 checks passed
@kjohnson kjohnson deleted the feature/form-builder-tags-categories-927 branch August 20, 2024 12:19
kjohnson added a commit that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants