-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Form Builder Tags, Categories #7463
Conversation
@kjohnson another thought here, have we already accounted for taxonomies in the v2 to v3 form migration process? If not, can you please add a migration step? |
@jonwaldstein thanks for the feedback on how to better separate this domain without using temporary form settings. Always good to get a second set of eyes with a "non-standard" approach. I'll get that updates. Also, I'll look into the form migration - good catch. |
…:impress-org/give into feature/form-builder-tags-categories-927
@jonwaldstein Re: Form Migration: I created a new task in Jira, see https://stellarwp.atlassian.net/browse/GIVE-1119. |
Co-authored-by: Jon Waldstein <jon@givewp.com>
Co-authored-by: Jon Waldstein <jon@givewp.com>
…:impress-org/give into feature/form-builder-tags-categories-927
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kjohnson nice job! just one more request for a unit test, otherwise looks good & ready for QA 🌈
Co-authored-by: Jon Waldstein <jon@givewp.com>
Build for QA, see https://github.com/impress-org/givewp/actions/runs/10455929311. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed manual QA tests.
Resolves GIVE-927
Description
This PR adds a new Domain for Form Taxonomies, which includes form tags and form categories as custom taxonomies.
Affects
Add the
$request
as an additional parameter to thegivewp_form_builder_updated
action hook.Testing Instructions
Enable form tags and/or form categories in the Give settings.
Create a new donation form and add/remove form tags and form categories.
Visuals