Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Collapse panel bodies by default #7464

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

kjohnson
Copy link
Member

@kjohnson kjohnson commented Jul 30, 2024

Resolves GIVE-808

Description

This PR collapses by default the multiple panel bodies of the Billing Address inspector controls, with the exception of the first.

Affects

This change is isolated to the Billing Address inspector settings.

Testing Instructions

Add a Billing Address block to the donation form and view the inspector settings.

Visuals

image

@kjohnson kjohnson marked this pull request as ready for review July 30, 2024 14:06
@jonwaldstein
Copy link
Contributor

@kjohnson please fill out the rest of the PR description with affects and testing instructions, as well as adding brackets to the Jira ticket.

@JoshuaHungDinh JoshuaHungDinh self-requested a review July 31, 2024 13:44
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go! (:

@kjohnson kjohnson merged commit 70874e6 into develop Jul 31, 2024
20 checks passed
@kjohnson kjohnson deleted the refactor/billing-address-settings-collapse-GIVE-808 branch July 31, 2024 13:56
@kjohnson
Copy link
Member Author

@kjohnson kjohnson restored the refactor/billing-address-settings-collapse-GIVE-808 branch July 31, 2024 16:33
@kjohnson kjohnson deleted the refactor/billing-address-settings-collapse-GIVE-808 branch July 31, 2024 16:55
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants