Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add nonce to paypal disconnect #7503

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Fix: add nonce to paypal disconnect #7503

merged 2 commits into from
Aug 26, 2024

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Aug 21, 2024 •
edited
Loading

Resolves GIVE-1135

Description

This updates the paypal commerce disconnect button with a nonce.

Affects

The PayPal commerce disconnect button

Visuals

N/A

Testing Instructions

  • Make sure the disconnect button still works as expected.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein marked this pull request as ready for review August 21, 2024 13:36
rickalday
rickalday approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@jonwaldstein jonwaldstein changed the base branch from master to develop August 26, 2024 16:47
@jonwaldstein jonwaldstein merged commit fc25cf7 into develop Aug 26, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/GIVE-1135 branch August 26, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickalday rickalday rickalday approved these changes

@kjohnson kjohnson kjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonwaldstein @rickalday @kjohnson