Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Update donor query order parameter #7550

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Chore: Update donor query order parameter #7550

merged 1 commit into from
Sep 25, 2024

Conversation

kjohnson
Copy link
Member

@kjohnson kjohnson commented Sep 25, 2024 •
edited
Loading

Resolves GIVE-1256

Description

This PR updates the order parameter used in the donor query.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Self Review of code and UX completed

@kjohnson kjohnson changed the base branch from develop to master September 25, 2024 15:34
@kjohnson kjohnson marked this pull request as ready for review September 25, 2024 15:34
jonwaldstein
jonwaldstein approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kjohnson
Copy link
Member Author

Build for QA, see https://github.com/impress-org/givewp/actions/runs/11038112756.

rickalday
rickalday approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual tests

@jonwaldstein jonwaldstein merged commit dc42aac into master Sep 25, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the chore/update-donor-query-order-param-GIVE-1256 branch September 25, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickalday rickalday rickalday approved these changes

@jonwaldstein jonwaldstein jonwaldstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjohnson @rickalday @jonwaldstein