Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #513

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Update README.md #513

merged 1 commit into from
Jul 29, 2019

Conversation

ascampos
Copy link
Contributor

Updated the link in the Usage with NodeJS section of the README to the improbable-eng scoped package.

Changes

  • updated link to grpc-web-node-http-transport npm package from the deprecated grpc-web-node-http-transport to @improbable-eng/grpc-web-node-http-transport

Verification

The README now links to the non-deprecated package in npm

johanbrandhorst
johanbrandhorst approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanbrandhorst johanbrandhorst merged commit 65a39de into improbable-eng:master Jul 29, 2019
@johanbrandhorst
Copy link
Contributor

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ascampos @johanbrandhorst