Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test utilities for REST APIs #41

Merged
merged 5 commits into from
Apr 10, 2015
Merged

Test utilities for REST APIs #41

merged 5 commits into from
Apr 10, 2015

Conversation

igaray
Copy link
Member

@igaray igaray commented Apr 9, 2015

No description provided.

@@ -3,18 +3,28 @@ erlang katana

![samuari](https://raw.github.com/unbalancedparentheses/katana/master/images/samurai.jpg)

Even if you love Erlang as I do, from time to time you might ask yourself why some functions you normally find in other languages are not part of the erlang's standard library. When you ask yourself that type of question you should remember that an estimated 2 million people are currently working in COBOL and 1.5 million new lines of COBOL code are written every day. After feeling bad for those developers, you should send a pull request to erlang katana with the functions you use on a daily basis.
Even if you love Erlang as I do, from time to time you might ask yourself why
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"I" -> "we" ;)

@elbrujohalcon
Copy link
Member

@igaray maybe the functions (or the module) should have less generic names (i.e. including the word rest somewhere)

@igaray
Copy link
Member Author

igaray commented Apr 10, 2015

Updated

-type test_subject() :: status | headers | body.
-type match_type() :: exact | partial.

-spec assert_response(test_subject(), match_type(), map(), chtc:response()) -> ok.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Elvis:

Line 11 is too long: -spec assert_response(test_subject(), match_type(), map(), chtc:response()) -> ok..

elbrujohalcon pushed a commit that referenced this pull request Apr 10, 2015
Test utilities for REST APIs
@elbrujohalcon elbrujohalcon merged commit 1e5775e into master Apr 10, 2015
@elbrujohalcon elbrujohalcon deleted the igaray.test_utils branch November 6, 2015 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants