Skip to content
This repository has been archived by the owner on May 30, 2019. It is now read-only.

Nicknames do not preserve their uppercase letters in queries #1

Closed
qwertfisch opened this issue Apr 14, 2014 · 2 comments
Closed

Nicknames do not preserve their uppercase letters in queries #1

qwertfisch opened this issue Apr 14, 2014 · 2 comments

Comments

@qwertfisch
Copy link

Description and steps to reproduce

When I start a private chat (query) with a user whose nickname uses uppercase letters, the query will have the name lowercased. E.g. a query to NickServ will have nickserv as title.

Impacts

This is at first only annoying because I recognize my contacts also in exact writing, and even if IRC does not distinguish between lower und upper case, it is not what I expect.

The second effect is worse: I use ZNC as bouncer which keeps logs from conversations on the server. When I start e.g. a query with NickServ, ZNC creates a file NickServ_[date].log where all messages from NickServ are logged. But since Atomic starts indeed a conversation with nickserv, ZNC also creates a file nickserv_[date].log where just my messages are logged. So the conversation is split into two files, where normally it’s just the one file NickServ_[date].log.

Comments on the bug

It looks to me as if Atomic forcefully lowercases the nickname for queries (because it is written correctly in the user’s list), which is unnecessary and leads to other bugs as described above.

indrora added a commit that referenced this issue Apr 15, 2014
Queries with users (and channels) which are MixedCase (e.g. NickServ) now have their names mangled properly on bouncers like ZNC.
@indrora
Copy link
Owner

indrora commented Apr 15, 2014

Super-simple fix.

Confirmed for me:

-rw-r--r-- 1 indrora users 1770 Apr 15 21:34 NickServ_20140415.log
-rw-r--r-- 1 indrora users 3758 Apr 15 21:42 #freenode_20140415.log

@qwertfisch
Copy link
Author

Thank you very much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants