Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Outputs Mark II #107

Closed
wants to merge 3 commits into from

Conversation

jipperinbham
Copy link
Contributor

_NOTE_
_BREAKING CHANGE_
Once this is merged, all existing config.toml files will be invalid and need to be updated. All examples in the project have been updated with the new format.

Attempt to move the InfluxDB client into an outputs pkg to allow for different outputs in the future.

@sparrc there's still some merge conflicts but I've done my best to get everything as close to master as possible where I can. Everything has been go veted and golinted.

@pauldix
Copy link
Member

pauldix commented Aug 12, 2015

Output interface should have a Close() error method so Telegraf can be cleanly shut down. Maybe in a separate PR?

I'm cool with the breaking change. Sad we have to make it, but everyone will be better for it :)

@jipperinbham
Copy link
Contributor Author

Good thought on adding Close() to the interface. As soon as #109 is merged, I can get that in shortly after.

I made a few attempts to not make it such a breaking change but couldn't ever settle on a config format that didn't seem like magic.

sparrc added a commit that referenced this pull request Aug 12, 2015
sparrc added a commit that referenced this pull request Aug 12, 2015
Merge of PR #107, Allow Telegraf to output data to multiple locations beyond InfluxDB, such as Riemann or Kafka
@sparrc
Copy link
Contributor

sparrc commented Aug 12, 2015

Closing this PR because it got covered by PR #109, apologies that most of your commits got covered up, the rebasing got a little bit crazy ;-)

Thanks so much @jipperinbham! This is huge!

@sparrc sparrc closed this Aug 12, 2015
@jipperinbham
Copy link
Contributor Author

@sparrc thanks for all the help getting this in! Hope to get started on a new output soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants