Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate AWS credentials, Cloudwatch dimension wilcards #1208

Merged
merged 8 commits into from
May 25, 2016

Conversation

johnrengelman
Copy link
Contributor

Rebased & retargeted version of #1155

@sparrc
Copy link
Contributor

sparrc commented May 19, 2016

few things:

  1. update CHANGELOG.md
  2. There are some READMEs that will need to be updated for each aws plugin

@johnrengelman
Copy link
Contributor Author

I've updated the ChangeLog and the READMEs

@sparrc
Copy link
Contributor

sparrc commented May 24, 2016

LGTM but please rebase your changes so I can merge

@johnrengelman
Copy link
Contributor Author

@sparrc rebased and I relocate my changelog entries to to "unreleased" section.

@johnrengelman
Copy link
Contributor Author

And rebased again.
Having the changelog submitted as part of the PR is quite a pain. it means that every PR has to be rebased immediately before merging because they all change the same file.

@sparrc
Copy link
Contributor

sparrc commented May 24, 2016

sorry but it's not always this painful, you've made quite a large change to the changelog at the same time that I was making a release....

@sparrc sparrc merged commit 5f3a91b into influxdata:master May 25, 2016
@sparrc
Copy link
Contributor

sparrc commented May 25, 2016

thanks @johnrengelman

if !hasWilcard(m.Dimensions) {
dimensions := make([]*cloudwatch.Dimension, len(m.Dimensions))
for k, d := range m.Dimensions {
fmt.Printf("Dimension [%s]:[%s]\n", d.Name, d.Value)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this print intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, that's was some lingering debugging. It should get removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants