Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option "total/perdevice" to Docker input #1525

Merged
merged 1 commit into from
Jul 21, 2016

Conversation

PierreF
Copy link
Contributor

@PierreF PierreF commented Jul 20, 2016

Required for all PRs:

  • CHANGELOG.md updated
  • Sign CLA (if not already signed)

Like cpu plugin, add two option "total" and "perdevice" to send network
and diskio metrics either per device and/or the sum of all devices.

By default, the old behavior of only per-device metrics is keep. User needs to change configuration if total is wanted.

@sparrc
Copy link
Contributor

sparrc commented Jul 20, 2016

looks good, but could you change perdevice to per_container?

@PierreF
Copy link
Contributor Author

PierreF commented Jul 20, 2016

It's always per container. Here device is eth0, eth1... (network metrics) or 8:0, 8:1... (blkio metrics).

@sparrc
Copy link
Contributor

sparrc commented Jul 20, 2016

ah, got it, thx

@PierreF
Copy link
Contributor Author

PierreF commented Jul 20, 2016

I will improve the comment to give example of what "device" is and write that total is per container and not global total of all containers

Like cpu plugin, add two option "total" and "perdevice" to send network
and diskio metrics either per device and/or the sum of all devices.
@PierreF
Copy link
Contributor Author

PierreF commented Jul 20, 2016

Done, updated the comment in configuration file

@sparrc sparrc merged commit 0462af1 into influxdata:master Jul 21, 2016
bitmori pushed a commit to bitmori/telegraf that referenced this pull request Jul 23, 2016
Like cpu plugin, add two option "total" and "perdevice" to send network
and diskio metrics either per device and/or the sum of all devices.
@PierreF PierreF deleted the docker-total branch August 4, 2018 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants