Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert Redis to use URI, support Redis AUTH #16

Merged
merged 1 commit into from
Jun 23, 2015

Conversation

jipperinbham
Copy link
Contributor

These changes allow for someone to collect stats from Redis that has AUTH configured. In order to accomplish this, I changed the logic to accept a URI (i.e. redis://x:password@localhost).

@evanphx
Copy link
Contributor

evanphx commented Jun 22, 2015

@jipperinbham This is a great PR but it means that the code ONLY accepts URLs. Can you modify the PR such that if the string is not a URL it is treated the same as it is now?

@jipperinbham
Copy link
Contributor Author

@evanphx I've updated the PR to fallback to a string based address if the Scheme is not provided. Also, squashed the commits to 1.

@evanphx
Copy link
Contributor

evanphx commented Jun 23, 2015

@jipperinbham Thanks!

evanphx added a commit that referenced this pull request Jun 23, 2015
convert Redis to use URI, support Redis AUTH
@evanphx evanphx merged commit 043b171 into influxdata:master Jun 23, 2015
@jipperinbham jipperinbham deleted the redis_auth branch July 4, 2015 20:14
siva-vunet pushed a commit to siva-vunet/telegraf that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants