Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port tag to apache plugin #220

Closed
wants to merge 2 commits into from
Closed

Add port tag to apache plugin #220

wants to merge 2 commits into from

Conversation

neezgee
Copy link
Contributor

@neezgee neezgee commented Sep 22, 2015

I need to monitor several apache instances on single host. Port number is only way of distinguishing them.

} else {
htag = h
return map[string]string{"server": h, "port": "80"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if this just defaulted to having the "server" tag only, since this could be 443 in the case of https

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that, or check for https at the beginning of the string and use port 443 if it's there

@neezgee
Copy link
Contributor Author

neezgee commented Sep 22, 2015

Yes, just defaulting to port 80 is definetly bad. Fixed.

@sparrc
Copy link
Contributor

sparrc commented Sep 22, 2015

awesome, thanks a bunch @neezgee 👍

@sparrc
Copy link
Contributor

sparrc commented Sep 22, 2015

closed with 72edc3c

@sparrc sparrc closed this Sep 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants