Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add HTTP basic auth support to the http_listener input plugin #3496

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

3van
Copy link
Contributor

@3van 3van commented Nov 22, 2017

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Does what it says on the tin. Needed it for a specific use case, and saw no reason for it to not be there, so here we are.

@3van
Copy link
Contributor Author

3van commented Dec 1, 2017

@danielnelson any chance this could land in a release sometime soon? I’d love to get our build process off of my fork.

@danielnelson danielnelson added this to the 1.6.0 milestone Dec 1, 2017
@danielnelson danielnelson added area/influxdb feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Dec 1, 2017
@danielnelson
Copy link
Contributor

I will try to review for 1.6.

@danielnelson
Copy link
Contributor

Looks good but can you remove the HTTPS test code, I don't think it is necessary to test that for this code.

add basic auth config to default telegraf.conf

removed https tests
@3van
Copy link
Contributor Author

3van commented Feb 28, 2018

Ugh, sorry, I totally forgot about this (until someone reminded me that our builds were still happening from my fork, haha). HTTPS tests removed now!

@danielnelson danielnelson merged commit def76ac into influxdata:master Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/influxdb feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants