Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker healthcheck (cont. of #3493) #3666

Merged
merged 4 commits into from
Jan 13, 2018
Merged

Docker healthcheck (cont. of #3493) #3666

merged 4 commits into from
Jan 13, 2018

Conversation

jmccann
Copy link
Contributor

@jmccann jmccann commented Jan 12, 2018 •
edited
Loading

This is a continuation of #3493

I fixed the tests to pass by adding mock data to the container inspect data that is being referenced.

Let me know if anything else is required.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@jmccann jmccann changed the title Docker healthcheck passing tests Docker healthcheck (cont. of #3493) Jan 12, 2018
@danielnelson danielnelson added this to the 1.6.0 milestone Jan 12, 2018
@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jan 12, 2018
@danielnelson danielnelson merged commit 7ab0d50 into influxdata:master Jan 13, 2018
@danielnelson danielnelson mentioned this pull request Jan 13, 2018
Closed
3 tasks
@jmccann jmccann deleted the docker_healthcheck_passing_tests branch January 13, 2018 15:35
maxunt pushed a commit that referenced this pull request Jun 26, 2018
@jmccann @danielnelson
Add container health metrics to docker input (#3666)
286dcab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jmccann @danielnelson @arindamchoudhury