#4699 Improve how the datadog plugin uses Metric.Fields and Metric.Tags #4803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
approved these changes
Oct 3, 2018
plugins/outputs/datadog/datadog.go
Outdated
| @@ -76,6 +76,10 @@ func (d *Datadog) Write(metrics []telegraf.Metric) error { | |||
|
|
|||
| for _, m := range metrics { | |||
| if dogMs, err := buildMetrics(m); err == nil { | |||
| tagMap := m.Tags() | |||
| metricTags := buildTags(tagMap) | |||
There was a problem hiding this comment.
This is much better but if you want to take it even further you could use TagList() to build the tags list. TagList is always sorted so you can avoid the sort as well.
danielnelson
added
the
performance
|
Tests should pass if you add the changes made by |
|
@danielnelson Thanks for the feedback! I made the changes that you suggested for |
glinton
approved these changes
Oct 4, 2018
rgitzel
pushed a commit
to rgitzel/telegraf
that referenced
this pull request
Oct 17, 2018
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
@danielnelson This PR addresses the feedback in #4699. I replaced the use of
Metric.FieldswithMetric.FieldListand reduced how oftenMetric.Tagsis called (it didn't look like usingTagListmade sense)Since the changes were internal, I left the existing tests as is.