Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : size options can come with units (KB, MiB, ...) #4852

Merged
merged 12 commits into from
Oct 19, 2018

Conversation

Samuel-BF
Copy link
Contributor

What it does

Some options can now be expressed either as int (without quotes, representing the value in Bytes), either as strings with units ("100KiB", "-5MB" ...). These options are :

  • inputs/filecount: size (minimum or maximum size of file to consider)
  • inputs/http_listener: max_body_size and max_line_size
  • inputs/socket_listener : read_buffer_size
  • ouputs/influxdb : udp_payload (maximum packet size for UDP packet)

I've not modified max_message_bytes from outputs/kafka because 1. the parallel option in kafka is also expressed in bytes without units and 2. it would be necessary to rename the option.

The default configuration is also updated to show examples with units.

How it works

It adds the internal.Size type, which can be used by plugins. The configuration option is processed by (*Size) UnmarshalTOML function, which uses units package.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@Samuel-BF Samuel-BF changed the title Feature/size with units Feature : size options can come with units (KB, MiB, ...) Oct 12, 2018
@glinton glinton added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Oct 12, 2018
@glinton glinton self-requested a review October 12, 2018 18:01
@danielnelson
Copy link
Contributor

Looks good, just need to resolve the conflicts caused when we aliased http_listener to influxdb_listener and moved the code. The new http_listener_v2 plugin could probably take advantage of this change.

@danielnelson danielnelson added this to the 1.9.0 milestone Oct 19, 2018
@Samuel-BF
Copy link
Contributor Author

@danielnelson : done.

@danielnelson danielnelson merged commit 589d058 into influxdata:master Oct 19, 2018
@Samuel-BF Samuel-BF deleted the feature/size-with-units branch December 14, 2018 10:42
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants