Add support for Enterprise repos in Github plugin #6194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanempope
commented
Aug 2, 2019
| return g.newGithubClient(httpClient) | ||
| } | ||
|
|
||
| func (g *GitHub) newGithubClient(httpClient *http.Client) (*github.Client, error) { |
There was a problem hiding this comment.
I do wonder if there's a better function name for this...
shanempope
commented
Aug 2, 2019
shanempope
commented
Aug 2, 2019
|
|
||
| func (g *GitHub) newGithubClient(httpClient *http.Client) (*github.Client, error) { | ||
| if g.EnterpriseBaseURL != "" { | ||
| return github.NewEnterpriseClient(g.EnterpriseBaseURL, "", httpClient) |
There was a problem hiding this comment.
the "" in the 2nd arg is the Enterprise Upload URL that isn't necessary for the plugin. You can compare this commit to my first commit, but I checked go-github and as far as I can tell it isn't necessary for this plugin.
danielnelson
added
the
feat
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
#6162