Added source and port tags in jenkins_job metrics #6844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #6842 |
vikkyomkar
changed the title
vikkyomkar
changed the title
danielnelson
suggested changes
Jan 3, 2020
danielnelson
added
the
performance
|
@danielnelson Code is updated as per the suggestion. Now
Can you please review the changes now ? |
danielnelson
removed
the
performance
danielnelson
approved these changes
Jan 10, 2020
danielnelson
added
the
feat
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
-> Earlier "url.Parse" function was called "N Nodes" and "J Jobs" times which is now reduced to just 2 calls by creating separate function for URL parsing and source, port split.
-> Added missing source and port tags in jenkins_job metrics
closes #6842