Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time crate support for Timestamp #151

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pbzweihander
Copy link

Description

{ describe your changes here }

Checklist

  • Formatted code using cargo fmt --all
  • Linted code using clippy
    • with reqwest feature: cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features serde,derive,reqwest-client-rustls -- -D warnings
    • with surf feature: cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features serde,derive,hyper-client -- -D warnings
  • Updated README.md using cargo doc2readme -p influxdb --expand-macros
  • Reviewed the diff. Did you leave any print statements or unnecessary comments?
  • Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment

@msrd0
Copy link
Collaborator

msrd0 commented Mar 29, 2024

Thanks, adding time support is something I wanted to see for a long time but never got around to it!

I haven't actually checked where exactly we use chrono, but if it's only for the Timestamp, do you think you could make both chrono and time optional? I feel like most users wouldn't need both at the same time

@pbzweihander
Copy link
Author

@msrd0 I've updated the PR!

Copy link
Collaborator

@msrd0 msrd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Empty2k12
Copy link
Collaborator

The tests need to be adapted to test both chrono and time independently. The tests should enable the features. Ci is currently failing since chrono could not be found in the test.

@msrd0
Copy link
Collaborator

msrd0 commented Apr 2, 2024

The tests need to be adapted to test both chrono and time independently.

I'm not sure that's necessary. These two features don't seem to conflict each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants