Add annotation to tag an ent field as an additionalSubject #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
mikemrm
approved these changes
Jan 25, 2024
tylerauerbeck
approved these changes
Jan 29, 2024
mikemrm
added a commit
to infratographer/tenant-api
that referenced
this pull request
Apr 4, 2024
This corrects the test which accounts for updates sending AuthRelationshipRequest events on tenant updates. This is no longer the case as of infratographer/x v0.4.0. Introduced in [infratographer/x#185](infratographer/x#185] relationship events are only sent on Create and Delete operations. Signed-off-by: Mike Mason <mimason@equinix.com>
mikemrm
added a commit
to infratographer/tenant-api
that referenced
this pull request
Apr 5, 2024
* Update module go.infratographer.com/x to v0.4.0 * AuthRelationshipRequest counts are no longer sent for updates This corrects the test which accounts for updates sending AuthRelationshipRequest events on tenant updates. This is no longer the case as of infratographer/x v0.4.0. Introduced in [infratographer/x#185](infratographer/x#185] relationship events are only sent on Create and Delete operations. Signed-off-by: Mike Mason <mimason@equinix.com> * upgrade infratographer/x to v0.5.0 Signed-off-by: Mike Mason <mimason@equinix.com> * fix new ci requirements with go upgrade Signed-off-by: Mike Mason <mimason@equinix.com> * regenerate schema Signed-off-by: Mike Mason <mimason@equinix.com> * remove go version pinning. issue marked resolved Signed-off-by: Mike Mason <mimason@equinix.com> --------- Signed-off-by: Mike Mason <mimason@equinix.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Mike Mason <mimason@equinix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the events re-work, we were able to tag an annotation on an ent schema field to be included as an
additionalSubjectin the event message.Proposing to bring that back, so any api in the infratographer ecosystem does not have to manually manage additional subjects in the generated event hooks.